Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add quote for partition name(close #14477) (#14793) #16315

Merged
merged 6 commits into from
Jun 1, 2020
Merged

executor: add quote for partition name(close #14477) (#14793) #16315

merged 6 commits into from
Jun 1, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 13, 2020 •
edited by zimulala
Loading

cherry-pick #14793 to release-3.0

conflicts:
ddl/db_partition_test.go
executor/show.go

Signed-off-by: Rustin-Liu [email protected]

What problem does this PR solve?

solve #14477

What is changed and how it works?

Add quote.

Check List

Tests

  • Unit test

Code changes

None

Side effects

None
Related changes

None

Release note

None

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 13, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 13, 2020
Merged
@sre-bot sre-bot added sig/sql-infra SIG: SQL Infra contribution This PR is from a community contributor. status/all-tests-passed type/3.0-cherry-pick labels Apr 13, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Apr 13, 2020
@zimulala
Copy link
Contributor

/run-unit-test

tangenta
tangenta approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AilinKid
AilinKid reviewed Apr 13, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 13, 2020

Your auto merge job has been accepted, waiting for 16309, 16179, 16188

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 13, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 13, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 13, 2020

@sre-bot merge failed.

@zimulala
Copy link
Contributor

/run-common-test tidb-test=pr/1035
/run-integration-common-test tidb-test=pr/1035

@zimulala
Copy link
Contributor

/run-common-test tidb-test=pr/1035
/run-integration-common-test tidb-test=pr/1035

@zz-jason
Copy link
Member

@zimulala Seems the integration test still fails even with the corresponding test case changes. PTAL.

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

@sre-bot, please update your pull request.

1 similar comment
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

@sre-bot, please update your pull request.

@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

@sre-bot, please update your pull request.

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

@sre-bot merge failed.

@sre-bot
Copy link
Contributor Author

sre-bot commented May 28, 2020

@sre-bot, please update your pull request.

@zimulala
Copy link
Contributor

/run-common-test tidb-test=pr/1035
/run-integration-common-test tidb-test=pr/1035

@zimulala
Copy link
Contributor

zimulala commented Jun 1, 2020

/run-all-tests

@zimulala
Copy link
Contributor

zimulala commented Jun 1, 2020

/run-common-test tidb-test=pr/1035
/run-integration-common-test tidb-test=pr/1035

@zimulala
Copy link
Contributor

zimulala commented Jun 1, 2020

/run-integration-br-test

1 similar comment
@zimulala
Copy link
Contributor

zimulala commented Jun 1, 2020

/run-integration-br-test

@zimulala
Copy link
Contributor

zimulala commented Jun 1, 2020

/run-common-test tidb-test=pr/1035
/run-integration-common-test tidb-test=pr/1035

bb7133
bb7133 approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit 90eb010 into pingcap:release-3.0 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@bb7133 bb7133 bb7133 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

@zimulala zimulala

Labels
contribution This PR is from a community contributor. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sre-bot @zimulala @zz-jason @bb7133 @AilinKid @tangenta @Rustin170506