-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix error PushDownNot for contiguous NOT #16108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16108 +/- ##
===========================================
Coverage 80.3807% 80.3807%
===========================================
Files 506 506
Lines 136514 136514
===========================================
Hits 109731 109731
Misses 18223 18223
Partials 8560 8560 |
#16094 is the same bug-fix on release-3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
/run-all-tests |
@XuHuaiyu merge failed. |
/run-all-tests |
/run-integration-common-test |
/run-unit-test |
unit-test fail because of #15979 |
cherry pick to release-4.0 in PR #16417 |
What problem does this PR solve?
Issue Number: close #15725
Problem Summary:
The issue exposes 2 problems:
double negation is handled wrongly in PushDownNot. This problem only appears in release-3.0 and release-3.1 because of
problem 2
.If
not
appears even number of times in an expression tree, thenot
can not be eliminated successfully.(not not not not a)
can be optimized to(not not a)
here.What is changed and how it works?
Proposal: xxx
What's Changed:
Do not eliminate the innermost
NOT
.How it Works:
Related changes
N/A
I'll push specified PR to release branch.
Check List
Tests
Side effects
N/A
Release note