Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add warning when use_index_merge hint's index names are invalid (#15960) #16036

Merged
merged 1 commit into from
Apr 3, 2020
Merged

planner: add warning when use_index_merge hint's index names are invalid (#15960) #16036

merged 1 commit into from
Apr 3, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 3, 2020

cherry-pick #15960 to release-4.0

What problem does this PR solve?

Problem Summary:
Add warning when use_index_merge(table, index) hint contains invalid index name.

What is changed and how it works?

How it Works:
check the index names when add hints into DataSource.

Related changes

  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Integration test

Side effects

@sre-bot sre-bot requested a review from a team as a code owner April 3, 2020 03:34
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 3, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 3, 2020
Merged
@sre-bot sre-bot added sig/planner SIG: Planner type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 3, 2020
@sre-bot sre-bot requested review from lzmhhh123 and winoros April 3, 2020 03:34
@ghost ghost requested a review from eurekaka April 3, 2020 03:34
eurekaka
eurekaka reviewed Apr 3, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lzmhhh123
lzmhhh123 approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 3, 2020
@zz-jason zz-jason merged commit af3db5d into pingcap:release-4.0 Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @eurekaka @lzmhhh123 @zz-jason @francis0407