info_schema: fix memtable column flag type #15944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
github-actions
bot
added
sig/sql-infra
Codecov Report
@@ Coverage Diff @@
## master #15944 +/- ##
===========================================
Coverage 80.5056% 80.5056%
===========================================
Files 505 505
Lines 135598 135598
===========================================
Hits 109164 109164
Misses 17938 17938
Partials 8496 8496 |
|
/run-all-tests |
zimulala
added
the
status/can-merge
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #16004 |
zimulala
pushed a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
when building a memory table, TiDB will use flag =
unsignedto fill those columns with number type, such asTypeLong,TypeLonglong... exceptTypevarcharandTypeblob.That means it will ignore the user-specified flag in the table definition.
What is changed and how it works?
build memory table with user-defined flag rather than the default unsigned
Tests
Release note: info_schema: fix memtable column flag type