Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: update the label of component/DDL #15418

Merged
merged 2 commits into from
Mar 17, 2020
Merged

.github: update the label of component/DDL #15418

merged 2 commits into from
Mar 17, 2020

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 17, 2020 •
edited
Loading

What problem does this PR solve?

Update the label of component/DDL

Check List

Tests

  • No code

Release note

@zimulala
Copy link
Contributor Author

PTAL @zz-jason @qw4990

@codecov
Copy link

codecov bot commented Mar 17, 2020 •
edited
Loading

Codecov Report

Merging #15418 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15418   +/-   ##
===========================================
  Coverage   80.8531%   80.8531%           
===========================================
  Files           502        502           
  Lines        135735     135735           
===========================================
  Hits         109746     109746           
  Misses        17614      17614           
  Partials       8375       8375

zz-jason
zz-jason reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/build status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2020
@zz-jason zz-jason requested a review from qw4990 March 17, 2020 06:49
qw4990
qw4990 approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

/run-all-tests

@sre-bot sre-bot merged commit e0de04d into pingcap:master Mar 17, 2020
@zimulala zimulala deleted the label-ddl branch March 18, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/build status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zimulala @sre-bot @zz-jason @qw4990