config: bug fix for the config-check mode #15190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15190 +/- ##
===========================================
Coverage 80.3263% 80.3263%
===========================================
Files 503 503
Lines 133483 133483
===========================================
Hits 107222 107222
Misses 17884 17884
Partials 8377 8377 |
overvenus
approved these changes
Mar 7, 2020
|
|
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
chenlx0
pushed a commit
to chenlx0/tidb
that referenced
this pull request
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In this PR(#14750), we support updating configs online according to PD, and the first step to implement this feature(#13660) is to register the current config to PD when TiDB starts.
But in the config-check mode(when the
config-checkflag is true), we don't need to do this register operation.What is changed and how it works?
If the
config-checkflag is true, exit immediately after checking the config.Check List
Tests