Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: update codeowner rule for sig exec and planner #15079

Merged
merged 5 commits into from
Mar 6, 2020

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Mar 3, 2020

What problem does this PR solve?

Not a problem. I found that some executor related PRs are not automatically request someone to review since we have already expand expression SIG to execution SIG.

What is changed and how it works?

Update the codeowner rule for SIG execution and planner.

Check List

Tests

  • No code

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #15079 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15079   +/-   ##
===========================================
  Coverage   80.3269%   80.3269%           
===========================================
  Files           503        503           
  Lines        132511     132511           
===========================================
  Hits         106442     106442           
  Misses        17687      17687           
  Partials       8382       8382

@zz-jason zz-jason requested review from qw4990 and winoros March 3, 2020 02:15
@zz-jason zz-jason added the type/enhancement The issue or PR belongs to an enhancement. label Mar 3, 2020
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2020
@zz-jason zz-jason requested review from SunRunAway and removed request for qw4990 and winoros March 5, 2020 17:03
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 6, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 6, 2020

@zz-jason merge failed.

@SunRunAway
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 6, 2020

/run-all-tests

@sre-bot sre-bot merged commit 5aca2c4 into pingcap:master Mar 6, 2020
@zz-jason zz-jason deleted the update-code-owner branch March 6, 2020 09:37
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants