expression: add builtin function WEIGHT_STRING()
#14792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
SunRunAway and
XuHuaiyu
and removed request for
a team
|
PTAL @wjhuang2016 @qw4990 @kennytm |
wjhuang2016
reviewed
Feb 17, 2020
| } | ||
|
|
||
| // TODO: refactor padding codes after padding is supported by collators. | ||
| switch b.padding { |
There was a problem hiding this comment.
Please update it since the padding PR is merged.
bb7133
force-pushed
the
bb7133/add_weight_string
branch
from
760b9b5 to
455e361
Compare
kennytm
reviewed
Feb 17, 2020
bb7133
force-pushed
the
bb7133/add_weight_string
branch
from
455e361 to
c65845b
Compare
bb7133
force-pushed
the
bb7133/add_weight_string
branch
4 times, most recently
from
01768e5 to
c96e628
Compare
|
PTAL @qw4990 @kennytm @wjhuang2016 |
qw4990
reviewed
Feb 21, 2020
wjhuang2016
reviewed
Feb 21, 2020
| c.Assert(test.expect, IsNil) | ||
| continue | ||
| } | ||
| res, err := result.ToString() |
There was a problem hiding this comment.
ToString may be wrong if the collation is general_ci
There was a problem hiding this comment.
That's fine, the string in Go does not have to be a valid utf8 sequence.
There was a problem hiding this comment.
I've updated the tests for utf8mb4_general_ci.
bb7133
force-pushed
the
bb7133/add_weight_string
branch
3 times, most recently
from
3070c68 to
93eb676
Compare
|
Addressed, PTAL @wjhuang2016 @qw4990 @kennytm |
djshow832
reviewed
Feb 24, 2020
expression/builtin_string_test.go
Outdated
Comment on lines
2320
to
2344
| {nil, "NONE", 0, nil}, | ||
| {7, "NONE", 0, nil}, | ||
| {"a", "NONE", 0, "a"}, | ||
| {"a ", "NONE", 0, "a "}, | ||
| {"中", "NONE", 0, "中"}, | ||
| {"中 ", "NONE", 0, "中 "}, | ||
| {nil, "CHAR", 5, nil}, | ||
| {7, "CHAR", 5, nil}, | ||
| {"a", "CHAR", 5, "a "}, | ||
| {"a ", "CHAR", 5, "a "}, | ||
| {"中", "CHAR", 5, "中 "}, | ||
| {"中 ", "CHAR", 5, "中 "}, | ||
| {nil, "BINARY", 5, nil}, | ||
| {7, "BINARY", 2, "7\x00"}, | ||
| {"a", "BINARY", 1, "a"}, | ||
| {"ab", "BINARY", 1, "a"}, | ||
| {"a", "BINARY", 5, "a\x00\x00\x00\x00"}, | ||
| {"a ", "BINARY", 5, "a \x00\x00\x00"}, | ||
| {"中", "BINARY", 1, "\xe4"}, | ||
| {"中", "BINARY", 2, "\xe4\xb8"}, | ||
| {"中", "BINARY", 3, "中"}, | ||
| {"中", "BINARY", 5, "中\x00\x00"}, |
There was a problem hiding this comment.
Test the result when expr is a datetime or some types else.
There was a problem hiding this comment.
It's kind of complicated to add them here, I've added the integration test and put those cases there, PTAL.
wjhuang2016
reviewed
Feb 24, 2020
wjhuang2016
reviewed
Feb 24, 2020
kennytm
added
status/LGT2
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@bb7133 merge failed. |
bb7133
force-pushed
the
bb7133/add_weight_string
branch
from
81d7f4f to
5f9604c
Compare
|
/run-all-tests |
wjhuang2016
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR tries to close #3580
Related parser PR: pingcap/parser#743
What is changed and how it works?
Add builtin-function
WEIGHT_STRING(). MySQL manual described most of its behavior except:stris of numeric types,WEIGHT_STRING()in MySQL returnsNULL, so does this implementation.stris of other types rather than string or numeric, the result ofWEIGHT_STRING()in MySQL is not cleared. I simply evaluated the input as string.Check List
Tests
Code changes
Side effects