executor: add metric to trace tikvTxn LockKeys time consume #14189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
coocood
reviewed
Dec 23, 2019
metrics/tikvclient.go
Outdated
| Namespace: "tidb", | ||
| Subsystem: "tikvclient", | ||
| Name: "pessimistic_lock_keys_duration", | ||
| Buckets: prometheus.ExponentialBuckets(0.001, 2, 30), // 1ms ~ 1073741s |
|
@jackysp PTAL |
lonng
reviewed
Dec 23, 2019
| Namespace: "tidb", | ||
| Subsystem: "tikvclient", | ||
| Name: "pessimistic_lock_keys_duration", | ||
| Buckets: prometheus.ExponentialBuckets(0.001, 2, 24), // 1ms ~ 16777s |
There was a problem hiding this comment.
Do we need the max to 16777s?
There was a problem hiding this comment.
The innodb_lock_wait_timeout session variable could be set to maximum 1073741824 seconds, so maybe it could be some big value
lonng
reviewed
Dec 23, 2019
| defer func() { | ||
| if err == nil { | ||
| if lockCtx.PessimisticLockWaited > 0 { | ||
| lockCtx.LockTimeWaited = time.Since(lockCtx.WaitStartTime) |
There was a problem hiding this comment.
Seems the field LockTimeWaited is unnecessary.
There was a problem hiding this comment.
This is used for slow query logging in the diff part2
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
/run-cherry-picker |
|
cherry pick to release-3.0 in PR #14204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add metric to trace pessimistic lock
LockKeystime consumeWhat is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansiblerepositoryRelease note