Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: remove useless tikvclient_backoff_total #14109

Merged
merged 3 commits into from
Dec 18, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Dec 18, 2019

Signed-off-by: Shuaipeng Yu [email protected]

What problem does this PR solve?

After pingcap/tidb-ansible#1067, tikvclient_backoff_total is useless anymore.

What is changed and how it works?

Remove it.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Start a cluster to check the metrics of KV backoff OPS in TiDB.

@coocood
Copy link
Member

coocood commented Dec 18, 2019

LGTM

@lysu
Copy link
Contributor

lysu commented Dec 18, 2019

please fix build

Signed-off-by: Shuaipeng Yu <[email protected]>
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 18, 2019
@jackysp
Copy link
Member Author

jackysp commented Dec 18, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Dec 18, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit 2cb5eb6 into pingcap:master Dec 18, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@jackysp jackysp deleted the cleanup_metrics branch February 27, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants