-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: support 'GLOBAL SCOPE' for tidb_enable_table_partition
#14062
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14062 +/- ##
===========================================
Coverage 80.2104% 80.2104%
===========================================
Files 483 483
Lines 121620 121620
===========================================
Hits 97552 97552
Misses 16318 16318
Partials 7750 7750 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tidb> show warnings; +---------+------+---------------------------------------------------+
| Level | Code | Message |
+---------+------+---------------------------------------------------+
| Warning | 8200 | Unsupported partition type, treat as normal table |
+---------+------+---------------------------------------------------+
the warning here is not suitable~
df111f9
to
f079dfc
Compare
Addressed, PTAL |
f079dfc
to
f9af11d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
/run-all-tests |
cherry pick to release-3.0 failed |
What problem does this PR solve?
This PR tries to support global scope for TiDB system variable
tidb_enable_table_partition
. Sometimes users may need to disableTABLE PARTITIONS
for a TiDB cluster, at this time, settingtidb_enable_table_partition
tooff
at global scope will be convenient.What is changed and how it works?
Add missing scope.
Check List
Tests
Code changes
Side effects
Related changes
Release note
tidb_enable_table_partition