Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: add codeowner rules for planner related packages #13863

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Dec 3, 2019

What problem does this PR solve?

make it possible to automatically assign reviewers for every planner related PR

What is changed and how it works?

add a codeowner rule for planner related packages,

Check List

Tests

  • No code

@zz-jason zz-jason requested a review from a team December 3, 2019 03:13
@ghost ghost requested review from alivxxx and lzmhhh123 and removed request for a team December 3, 2019 03:13
@zz-jason
Copy link
Member Author

zz-jason commented Dec 3, 2019

/rebuild

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member Author

zz-jason commented Dec 3, 2019

/rebuild

1 similar comment
@zz-jason
Copy link
Member Author

zz-jason commented Dec 3, 2019

/rebuild

@glorv
Copy link
Contributor

glorv commented Dec 3, 2019

/run-check_dev

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #13863 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13863   +/-   ##
===========================================
  Coverage   80.2655%   80.2655%           
===========================================
  Files           474        474           
  Lines        117941     117941           
===========================================
  Hits          94666      94666           
  Misses        15809      15809           
  Partials       7466       7466

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. labels Dec 3, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

/run-all-tests

@sre-bot sre-bot merged commit a4af0ae into pingcap:master Dec 3, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants