*: do not start slow-log timer before parsing #13846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
jackysp
requested review from
lysu and
crazycs520
and removed request for
lysu
Signed-off-by: Shuaipeng Yu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #13846 +/- ##
================================================
+ Coverage 80.3256% 80.7995% +0.4739%
================================================
Files 479 479
Lines 119211 121992 +2781
================================================
+ Hits 95757 98569 +2812
- Misses 15933 15954 +21
+ Partials 7521 7469 -52 |
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
jackysp
changed the title
Signed-off-by: Shuaipeng Yu <[email protected]>
|
PTAL @coocood |
Signed-off-by: Shuaipeng Yu <[email protected]>
|
LGTM |
|
PTAL @crazycs520 |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Dec 4, 2019
Conflicts: config/config_test.go session/session.go
sre-bot
pushed a commit
that referenced
this pull request
Dec 10, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Starting slow-log timer making most of the cost time of multi-query greater than slow-log-threshold, which prints too many useless logs.
What is changed and how it works?
Do not start slow-log timer before parsing.
Check List
Tests
Code changes
Related changes