Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix compatibility issue related to ADDDATE #13827

Merged
merged 4 commits into from
Dec 5, 2019

Conversation

js00070
Copy link
Contributor

@js00070 js00070 commented Nov 29, 2019

What problem does this PR solve?

try to fix issue #13822

What is changed and how it works?

modify the regular expression related to DATE string convertion.

Check List

Tests

  • Unit test

@js00070 js00070 requested a review from a team as a code owner November 29, 2019 18:00
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 29, 2019
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team November 29, 2019 18:00
@js00070 js00070 changed the title expression: expression: fix compatibility issue related to ADDDATE Nov 29, 2019
@js00070
Copy link
Contributor Author

js00070 commented Nov 29, 2019

/run-all-tests

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #13827 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13827   +/-   ##
===========================================
  Coverage   80.1536%   80.1536%           
===========================================
  Files           480        480           
  Lines        118954     118954           
===========================================
  Hits          95346      95346           
  Misses        16081      16081           
  Partials       7527       7527

@shenli
Copy link
Member

shenli commented Nov 30, 2019

@js00070 Thanks for your contribution!
Could please add a unit test case?

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 4, 2019
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

@js00070 merge failed.

@ngaut ngaut merged commit 73d951d into pingcap:master Dec 5, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@js00070 js00070 deleted the fix#13822 branch February 1, 2020 04:07
@wshwsh12
Copy link
Contributor

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 12, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #21008

ti-srebot added a commit that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants