executor: init the final recv channel of hash agg with enough chunk #13811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
commented
Nov 29, 2019
| e.executed = true | ||
| if chk.NumRows() > 0 { // but there are some data left |
There was a problem hiding this comment.
If there's remaining data in chk. The e.isChildReturnEmpty must be false. Thus we don't need to return it here.
SunRunAway
reviewed
Nov 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #13811 +/- ##
=========================================
Coverage 80.233% 80.233%
=========================================
Files 480 480
Lines 120413 120413
=========================================
Hits 96611 96611
Misses 16119 16119
Partials 7683 7683 |
qw4990
added
status/can-merge
|
/run-all-tests |
|
@winoros merge failed. |
|
/run-sqllogic-test |
…oros/tidb into hash-agg-final-inpu-parallel
|
/run-all-tests |
qw4990
approved these changes
Dec 6, 2019
|
Should we cherry-pick this PR to 3.0? |
|
I'm not sure. It's performance problem instead of bug. What's your opinion? |
emm, I also think it's better to pick it to v3.0. |
eggeek
pushed a commit
to eggeek/tidb
that referenced
this pull request
Dec 6, 2019
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Dec 6, 2019
sre-bot
pushed a commit
that referenced
this pull request
Dec 17, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #13806
What is changed and how it works?
Init the channel with enough chunk.
Check List
Tests