-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: use a deep copy for accessPath when clone DataSource #13620
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #13620 +/- ##
================================================
+ Coverage 79.9522% 79.9927% +0.0404%
================================================
Files 473 473
Lines 115724 115988 +264
================================================
+ Hits 92524 92782 +258
+ Misses 15944 15942 -2
- Partials 7256 7264 +8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your auto merge job has been accepted, waiting for 13621, 13470 |
/run-all-tests |
/run-cherry-picker |
cherry pick to release-2.1 in PR #13627 |
cherry pick to release-3.0 in PR #13628 |
What problem does this PR solve?
Before this PR:
After this PR:
What is changed and how it works?
When processing partition tables, we use a shallow copy for DataSouces. But
accessPaths
in DataSouces will be changed after that. So we need a deep copy here.Check List
Tests
Related changes
Release note