expression: add builtin function json_valid #12596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reminiscent
changed the title
json_valid
28 tasks
SunRunAway
reviewed
Oct 10, 2019
SunRunAway
reviewed
Oct 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #12596 +/- ##
================================================
- Coverage 79.8579% 79.8577% -0.0002%
================================================
Files 462 462
Lines 104865 104884 +19
================================================
+ Hits 83743 83758 +15
- Misses 14920 14930 +10
+ Partials 6202 6196 -6 |
zz-jason
reviewed
Oct 12, 2019
|
@SunRunAway @zz-jason @qw4990 PTAL |
zz-jason
reviewed
Oct 14, 2019
There was a problem hiding this comment.
after offline discussion with @Reminiscent, we decided to use 3 signatures to implement this function:
- json_valid for json input parameters
- json_valid for string input parameters
- json_valid for other type input parameters
|
/run-all-tests |
qw4990
approved these changes
Oct 15, 2019
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-3.0 failed |
SunRunAway
pushed a commit
to SunRunAway/tidb
that referenced
this pull request
Oct 15, 2019
This was referenced Oct 27, 2019
Reminiscent
added a commit
to Reminiscent/tidb
that referenced
this pull request
Nov 5, 2019
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Nov 14, 2019
Closed
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @Reminiscent PTAL. |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 21, 2020
Signed-off-by: sre-bot <[email protected]>
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add
json_validbuiltin function described #7546.What is changed and how it works?
See here for details.
Check List
Tests