-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix unordered trace events in row format #12314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12314 +/- ##
=========================================
Coverage 81.082% 81.082%
=========================================
Files 454 454
Lines 99128 99128
=========================================
Hits 80375 80375
Misses 12953 12953
Partials 5800 5800 |
The trace statement can print out a trace tree, however, in row format, the tree is unordered, where earlier events may be placed behind. Signed-off-by: lucklove <[email protected]>
493a359
to
15803e3
Compare
PTAL @tiancaiamao |
LGTM |
Once upon a time, the result is sorted, until I remove it by mistake. @lucklove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your auto merge job has been accepted, waiting for 12199, 12292 |
/run-all-tests |
cherry pick to release-3.0 failed |
@lucklove the bot failed to cherry pick this PR to release 3.0 and 3.1, could you manually in your spare time? |
@zz-jason OK, I'll do it |
cherry pick to release-3.1 failed |
The trace statement can print out a trace tree, however, in row
format, the tree is unordered, where earlier events may be placed
behind.
Signed-off-by: lucklove [email protected]
What problem does this PR solve?
The trace statement may result unordered events tree, for example:
session.ParseSQL
is behindsession.Compile
, it's not correct.What is changed and how it works?
Sort sub events before appending them into chunk.
Check List
Tests
Code changes
Side effects
Related changes
Release note