-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv,session: invalidate snapshot cache under pessimistic transaction #12147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action In a pessimistic transaction, the snapshotTS may change, so we should invalidate the cache if the snapshotTS changes
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Sep 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #12147 +/- ##
===========================================
Coverage 81.3581% 81.3581%
===========================================
Files 453 453
Lines 97356 97356
===========================================
Hits 79207 79207
Misses 12485 12485
Partials 5664 5664 |
I've updated the test case @coocood |
LGTM |
jackysp
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/tikv
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix a bug in the pessimistic transaction that the transaction snapshot doesn't invalidate its cache after the snapshotTS changes.
Expect:
Get:
What is changed and how it works?
In a pessimistic transaction, the snapshotTS may change, so we should invalidate
the cache if the snapshotTS changes
Check List
Tests