Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: change the query start time to the parsing time (#11159) #12109

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

zz-jason
Copy link
Member

cherry pick #11159 to release-3.0


What problem does this PR solve?

At present, the query start time is the time when it begins to execute. Haven't counted the query parse and compile time.

What is changed and how it works?

As the PR title says, changing the query start time to the parsing time.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@zz-jason zz-jason added type/enhancement The issue or PR belongs to an enhancement. type/3.0 cherry-pick labels Sep 10, 2019
@zz-jason zz-jason requested review from qw4990, lysu and jackysp and removed request for qw4990 September 10, 2019 03:32
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

Sorry @qw4990, you don't have permission to trigger auto merge event on this branch.

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 10, 2019
@jackysp jackysp added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Sep 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

/run-all-tests

@sre-bot sre-bot merged commit 34ad8c0 into pingcap:release-3.0 Sep 10, 2019
@zz-jason zz-jason deleted the cherry-pick/3.0-11159 branch October 14, 2019 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants