infoschema: use BucketMap to reduce cost of table/database creation #12056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12056 +/- ##
================================================
- Coverage 81.4856% 81.3427% -0.1429%
================================================
Files 447 448 +1
Lines 95758 95716 -42
================================================
- Hits 78029 77858 -171
- Misses 12171 12316 +145
+ Partials 5558 5542 -16 |
|
/run-all-tests |
|
@bb7133 Please add some proper labels. BTW, any update on this PR, seems no one is reviewing it? |
This was referenced Nov 6, 2019
zz-jason
added
component/infoschema
type/enhancement
|
@bb7133 Is there any benchmark result to show the performance improvement? |
|
BTW, the PR is conflicted with the master branch. |
|
@bb7133, please update your pull request. |
1 similar comment
|
@bb7133, please update your pull request. |
|
@bb7133 PR closed due to no update for a long time. Feel free to reopen it anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
use BucketMap to reduce the time duration of table/database creation
What is changed and how it works?
a
BucketMapis added to replace currentmapinInfoSchemaCheck List
Tests
Side effects
Related changes
NA
Release note
NA