load data : fix load data rowcount should added first before call colsToRow() #11980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11980 +/- ##
=======================================
Coverage 81.28% 81.28%
=======================================
Files 444 444
Lines 95139 95139
=======================================
Hits 77329 77329
Misses 12322 12322
Partials 5488 5488 |
|
LGTM |
imtbkcat
added
status/LGT2
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-2.1 failed |
|
/run-cherry-picker |
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Sep 3, 2019
…ingcap#11980) fix load data rowcount should added first before call colsToRow().
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Sep 3, 2019
winkyao
pushed a commit
that referenced
this pull request
Sep 3, 2019
winkyao
pushed a commit
that referenced
this pull request
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix a bug in load data when row with auto increment column.
I find the server-test is under the wrong logic when I do my last_insert_id job.
So I take this PR to fix it.
What is changed and how it works?
Check List
Tests
Related changes
Release note