-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix add unique index on partitioned table (by RANGE COLUMNS) failed #11946
Conversation
Signed-off-by: Lonng <[email protected]>
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11946 +/- ##
================================================
- Coverage 81.3468% 81.2134% -0.1334%
================================================
Files 443 443
Lines 95035 95015 -20
================================================
- Hits 77308 77165 -143
- Misses 12267 12356 +89
- Partials 5460 5494 +34 |
Signed-off-by: Lonng <[email protected]>
…fix-partition-range-col
Signed-off-by: Lonng <[email protected]>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry pick to release-3.0 failed |
Cherry-pick to release-3.0 after #11954 merged |
/run-cherry-picker |
cherry pick to release-3.0 in PR #11958 |
Signed-off-by: Lonng [email protected]
What problem does this PR solve?
What is changed and how it works?
The
Expr
field inPartitionInfo
is not always be assigned a value (e.g:PARTITION BY RANGE COLUMNS(...)
).This PR use columns in
PartitionInfo
directly if thePartitionInfo.Expr
is an empty string.Check List
Tests
Related changes
Release note