*: record query start time to session variables #11822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhang Jian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #11822 +/- ##
================================================
+ Coverage 81.4658% 81.4853% +0.0195%
================================================
Files 435 435
Lines 93854 93753 -101
================================================
- Hits 76459 76395 -64
+ Misses 11911 11883 -28
+ Partials 5484 5475 -9 |
Codecov Report
@@ Coverage Diff @@
## master #11822 +/- ##
===============================================
- Coverage 82.0784% 81.4504% -0.628%
===============================================
Files 435 435
Lines 96459 94126 -2333
===============================================
- Hits 79172 76666 -2506
- Misses 11807 11959 +152
- Partials 5480 5501 +21 |
qw4990
reviewed
Aug 22, 2019
qw4990
added
status/LGT2
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
@zz-jason do we need cherry-pick this to 2.1? it seems I will fix another problem related to slow log too :D |
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Sep 10, 2019
sre-bot
pushed a commit
that referenced
this pull request
Sep 11, 2019
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Oct 14, 2019
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Oct 14, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 14, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhang Jian [email protected]
What problem does this PR solve?
move the following 3 metrics from
StatementContexttoSessionVars:StatementContextwill be reset when the physical plan is executed. All the metrics are reset.What is changed and how it works?
As described above.
Check List
Tests
Code changes
Related changes