Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: make TestShowAnalyzeStatus more stable (#11090) #11684

Merged
merged 2 commits into from
Aug 9, 2019
Merged

executor: make TestShowAnalyzeStatus more stable (#11090) #11684

merged 2 commits into from
Aug 9, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Aug 8, 2019

Cherry pick #11090

@tiancaiamao @alivxxx
executor: make TestShowAnalyzeStatus more stable (pingcap#11090)
488ff35 
If TestShowAnalyzeStatus run parallelly with others, the results would be affected.
use a new testShowStatsSuite for it.
zz-jason
zz-jason reviewed Aug 8, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 8, 2019
@alivxxx alivxxx mentioned this pull request Aug 8, 2019
Merged
jackysp
jackysp approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 9, 2019

/run-all-tests

@sre-bot sre-bot merged commit 24380b6 into pingcap:release-3.0 Aug 9, 2019
@alivxxx alivxxx deleted the test branch August 9, 2019 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@jackysp jackysp jackysp approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/test status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alivxxx @sre-bot @jackysp @zz-jason @tiancaiamao