Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: make test stable by running TestPanicInRecvLoop unparallel with others #11572

Merged
merged 4 commits into from
Aug 2, 2019

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Make CI more stable

What is changed and how it works?

The fail point injected by TestPanicInRecvLoop affect other tests.
Use a lock to make it run unparalleled with others

Check List

Tests

  • Unit test

@tiancaiamao tiancaiamao added type/enhancement The issue or PR belongs to an enhancement. component/test labels Aug 1, 2019
@tiancaiamao
Copy link
Contributor Author

PTAL @winkyao @jackysp

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #11572 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #11572   +/-   ##
=========================================
  Coverage   81.219%   81.219%           
=========================================
  Files          426       426           
  Lines        91843     91843           
=========================================
  Hits         74594     74594           
  Misses       11883     11883           
  Partials      5366      5366

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/LGT1 Indicates that a PR has LGTM 1. needs-cherry-pick-3.0 labels Aug 2, 2019
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2019
@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2019

cherry pick to release-3.0 in PR #11579

sre-bot added a commit that referenced this pull request Aug 2, 2019
@tiancaiamao tiancaiamao deleted the test-stable branch August 9, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants