Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix a coding mistake #11393

Merged
merged 4 commits into from
Jul 24, 2019
Merged

server: fix a coding mistake #11393

merged 4 commits into from
Jul 24, 2019

Conversation

foreyes
Copy link
Contributor

@foreyes foreyes commented Jul 23, 2019

What problem does this PR solve?

This piece of codes looks strange, I think it may need to be fix?

What is changed and how it works?

@foreyes
Copy link
Contributor Author

foreyes commented Jul 23, 2019

PTAL. @AndreMouche

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #11393 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11393   +/-   ##
===========================================
  Coverage   81.3741%   81.3741%           
===========================================
  Files           423        423           
  Lines         90648      90648           
===========================================
  Hits          73764      73764           
  Misses        11574      11574           
  Partials       5310       5310

Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. needs-cherry-pick-2.1 and removed type/suggestion labels Jul 24, 2019
@eurekaka
Copy link
Contributor

/run-all-tests

@foreyes
Copy link
Contributor Author

foreyes commented Jul 24, 2019

/run-unit-test
/run-ci-test

@foreyes foreyes merged commit 99e4dd4 into master Jul 24, 2019
@foreyes foreyes deleted the foreyes-patch-1 branch July 24, 2019 03:34
@sre-bot
Copy link
Contributor

sre-bot commented Jul 24, 2019

cherry pick to release-3.0 in PR #11400

@sre-bot
Copy link
Contributor

sre-bot commented Jul 24, 2019

cherry pick to release-2.1 in PR #11401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants