-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: fix a coding mistake #11393
server: fix a coding mistake #11393
Conversation
PTAL. @AndreMouche |
Codecov Report
@@ Coverage Diff @@
## master #11393 +/- ##
===========================================
Coverage 81.3741% 81.3741%
===========================================
Files 423 423
Lines 90648 90648
===========================================
Hits 73764 73764
Misses 11574 11574
Partials 5310 5310 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-unit-test |
cherry pick to release-3.0 in PR #11400 |
cherry pick to release-2.1 in PR #11401 |
What problem does this PR solve?
This piece of codes looks strange, I think it may need to be fix?
What is changed and how it works?