Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: add "exec start-time" to GeneralEvent #11293

Merged
merged 5 commits into from
Jul 18, 2019
Merged

plugin: add "exec start-time" to GeneralEvent #11293

merged 5 commits into from
Jul 18, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jul 17, 2019

What problem does this PR solve?

add "exec start-time" to GeneralEvent to support TEP requirement.

What is changed and how it works?

for not break compatibility (old plugin can compile with new TiDB, vice versa) pass it though context.Context

Check List

Tests

  • Unit test

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Jul 17, 2019

/run-all-tests

@lysu lysu requested review from jackysp and tiancaiamao July 17, 2019 09:29
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #11293 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11293   +/-   ##
===========================================
  Coverage   81.2495%   81.2495%           
===========================================
  Files           423        423           
  Lines         90174      90174           
===========================================
  Hits          73266      73266           
  Misses        11597      11597           
  Partials       5311       5311

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jul 18, 2019

/run-all-tests

@kennytm kennytm added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2019
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2019
@imtbkcat
Copy link

@jackysp please approve this pr, I miss the approve privilege....

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented Jul 18, 2019

cherry pick to release-2.1 in PR #11321

@sre-bot
Copy link
Contributor

sre-bot commented Jul 18, 2019

cherry pick to release-3.0 in PR #11322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugin status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants