-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support PointGet plan when table has alias name #11270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11270 +/- ##
================================================
- Coverage 81.7927% 81.6642% -0.1286%
================================================
Files 426 426
Lines 94380 93473 -907
================================================
- Hits 77196 76334 -862
- Misses 11785 11786 +1
+ Partials 5399 5353 -46 |
@sduzh It should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
planner/core/point_get_plan.go
Outdated
@@ -334,36 +340,40 @@ func buildSchemaFromFields(ctx sessionctx.Context, dbName model.CIStr, tbl *mode | |||
return schema | |||
} | |||
|
|||
func getSingleTableName(tableRefs *ast.TableRefsClause) *ast.TableName { | |||
// return the ast node of queried table name and the alias string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the comment convention, for example: comment starting with function name / variable name; capitalize first character of beginning word and add .
in the end of sentences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests |
What problem does this PR solve?
fix #11149
What is changed and how it works?
Check List
Tests
Side effects
Related changes
tidb-ansible
repositorymanual tests