-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add config item for bind info lease #10725
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10725 +/- ##
================================================
+ Coverage 79.6565% 79.6676% +0.0111%
================================================
Files 414 414
Lines 87817 87865 +48
================================================
+ Hits 69952 70000 +48
+ Misses 12682 12680 -2
- Partials 5183 5185 +2 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #10725 +/- ##
================================================
+ Coverage 79.6565% 79.6676% +0.0111%
================================================
Files 414 414
Lines 87817 87865 +48
================================================
+ Hits 69952 70000 +48
+ Misses 12682 12680 -2
- Partials 5183 5185 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Fix #9606
What is changed and how it works?
Add one config item for the bind info lease and the default value is 3s.
Check List
Tests
Change the bind info lease to 0 and verifies that the two background goroutine does not exist.
Code changes
Side effects
Related changes