-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikvclient: print error logs only if necessary #10349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10349 +/- ##
===============================================
- Coverage 77.6897% 77.6677% -0.022%
===============================================
Files 411 411
Lines 85436 85455 +19
===============================================
- Hits 66375 66371 -4
- Misses 14101 14124 +23
Partials 4960 4960 |
@hicqu plz help add target host info into |
lysu
reviewed
May 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
/run-all-tests |
tiancaiamao
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When TiDB loses a connection to TiKV, it will try to re-establish it if necessary. Only in this case it needs to print error logs. If the connection is closed by TiDB itself, error logs is not necessary.
What is changed and how it works?
Move error log print code to better place.
Check List
Tests
No code.
We are working on adding a test framework for tikvclient. We will add a new check rule for that: if the
connArray
is closed, all goroutines created by it shoud exit gracefully.Code changes
No visible changes out of tikvclient.
Close tikv/client-go#19 and pingcap/go-ycsb#97.