Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: move out some code from http_handler.go #10071

Merged
merged 3 commits into from
Apr 9, 2019
Merged

server: move out some code from http_handler.go #10071

merged 3 commits into from
Apr 9, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Apr 8, 2019

What problem does this PR solve?

Move out some code out of the HTTP handler. So that it can be used if we construct a mem table stores the same thing.

What is changed and how it works?

Code movement and add new unit test.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

@winoros winoros requested review from crazycs520, lysu and alivxxx April 9, 2019 04:47
zz-jason
zz-jason reviewed Apr 9, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2019
lysu
lysu approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2019
@winoros winoros merged commit 7acbe52 into pingcap:master Apr 9, 2019
@winoros winoros deleted the helper branch April 9, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lysu lysu lysu approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@alivxxx alivxxx Awaiting requested review from alivxxx

Assignees
No one assigned
Labels
component/server status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winoros @lysu @zz-jason