Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist framework: cancelled task status is overriden to running #44443

Closed
D3Hunter opened this issue Jun 6, 2023 · 3 comments
Closed

dist framework: cancelled task status is overriden to running #44443

D3Hunter opened this issue Jun 6, 2023 · 3 comments
Assignees
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 6, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  • start task
  • task process normal flow, but before it update task status as running, the task is cancelled
  • framework continue update, and override the task status as running

if task has already cancelled before entering running, the cancel status will be overrided

_, err := execSQL(stm.ctx, se, "update mysql.tidb_global_task set state = %?, dispatcher_id = %?, step = %?, state_update_time = %?, concurrency = %?, meta = %?, error = %? where id = %?",

2. What did you expect to see? (Required)

task status keep cancelled

3. What did you see instead (Required)

task is overrided to running

4. What is your TiDB version? (Required)

@D3Hunter D3Hunter added the type/bug The issue is confirmed as a bug. label Jun 6, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Jun 7, 2023
@Defined2014 Defined2014 added affects-7.1 This bug affects the 7.1.x(LTS) versions. and removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Jun 9, 2023
@wjhuang2016 wjhuang2016 assigned ywqzzy and unassigned wjhuang2016 Jun 9, 2023
@D3Hunter D3Hunter changed the title dist framework: task status is overrided dist framework: cancelled task status is overriden to running Jun 19, 2023
@bb7133 bb7133 added component/ddl This issue is related to DDL of TiDB. and removed sig/sql-infra SIG: SQL Infra labels Oct 9, 2023
@ywqzzy
Copy link
Contributor

ywqzzy commented Oct 20, 2023

/close

@ti-chi-bot ti-chi-bot bot closed this as completed Oct 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

@ywqzzy: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label Oct 24, 2023
@ywqzzy
Copy link
Contributor

ywqzzy commented Nov 15, 2023

close as #45932 fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants