Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BR: wait for tiflash synced after restore. #43828

Closed
3pointer opened this issue May 15, 2023 · 0 comments · Fixed by #43726
Closed

BR: wait for tiflash synced after restore. #43828

3pointer opened this issue May 15, 2023 · 0 comments · Fixed by #43726
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@3pointer
Copy link
Contributor

Enhancement

Current when doing restore with tiflash replica. BR only send ingest command to leader. and won't guarantee the learner replcia(tiflash) apply the ingest command. just let raft ensure the eventually consistency.

In some scenario. user may want to wait tiflash ready to serve and the config of sync replica between tikv and tiflash may not as fast as enough.

We need an option to make BR wait for tiflash ready to serve after restore.
@3pointer 3pointer added the type/enhancement The issue or PR belongs to an enhancement. label May 15, 2023
@3pointer 3pointer changed the title Restore didn't wait for tiflash synced. BR: wait for tiflash synced. May 15, 2023
@3pointer 3pointer changed the title BR: wait for tiflash synced. BR: wait for tiflash synced after restore. May 15, 2023
@3pointer 3pointer mentioned this issue May 15, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 27, 2023
@3pointer
br: pipeline wait tiflash synced (#43726)
0f20315 
close #43828
@Leavrth Leavrth added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Jun 28, 2023
This was referenced Jun 28, 2023
Merged
Merged
@Ivy-YinSu Ivy-YinSu added the component/br This issue is related to BR of TiDB. label Jul 7, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jul 10, 2023
@ti-chi-bot
br: pipeline wait tiflash synced (#43726) (#45017)
11b3d30 
close #43828
ti-chi-bot bot pushed a commit that referenced this issue Aug 16, 2023
@ti-chi-bot
br: pipeline wait tiflash synced (#43726) (#45018)
9d2e744 
close #43828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: pipeline wait tiflash synced 3pointer/tidb
3 participants
@3pointer @Leavrth @Ivy-YinSu