Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support index regions and updating the existed table rule when changing partition #33929

Closed
rleungx opened this issue Apr 13, 2022 · 3 comments · Fixed by #33925
Closed

Support index regions and updating the existed table rule when changing partition #33929

rleungx opened this issue Apr 13, 2022 · 3 comments · Fixed by #33925
Assignees
@rleungx
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 component/pd severity/major type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Apr 13, 2022 •
edited
Loading

Bug Report

In the previous implementation, if we set a table rule, the modification only can be applied to the existed partition. The newly added partition won't inherit the table attributes. Another problem is when we drop a partition, the range of this partition won't be deleted in the table rule. In these cases, we need to set the rule again.
@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Apr 13, 2022
@rleungx rleungx mentioned this issue Apr 13, 2022
Merged
4 tasks
@xhebox xhebox added type/bug The issue is confirmed as a bug. component/pd and removed type/enhancement The issue or PR belongs to an enhancement. labels Apr 13, 2022
@xhebox xhebox added severity/minor affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 labels Apr 13, 2022
@rleungx
Copy link
Member Author

rleungx commented Apr 13, 2022

ref tikv/pd#3839

@mayjiang0203
Copy link

/severity major

@ti-chi-bot ti-chi-bot added severity/major may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. labels Apr 13, 2022
@VelocityLight VelocityLight removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-4.0 This bug maybe affects 4.0.x versions. labels Apr 13, 2022
@rleungx
Copy link
Member Author

rleungx commented Apr 15, 2022

And Also we should support the index regions.

@rleungx rleungx changed the title Updating the existed table rule when changing partition Support index regions and updating the existed table rule when changing partition Apr 15, 2022
This was referenced Apr 15, 2022
Merged
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Apr 15, 2022
@rleungx
ddl: support index regions and updating the existed table rule when c…
2810c1d 
…hanging partition (#33925)

close #33929
@ti-srebot ti-srebot mentioned this issue Apr 15, 2022
Merged
4 tasks
This was referenced Apr 15, 2022
Merged
Closed
@ti-chi-bot ti-chi-bot mentioned this issue Apr 25, 2022
Closed
17 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 28, 2022
@ti-srebot
ddl: support index regions and updating the existed table rule when c…
0ce2900 
…hanging partition (#33925) (#34025)

close #33929
@rleungx rleungx mentioned this issue Apr 29, 2022
Merged
1 task
ti-chi-bot pushed a commit that referenced this issue Jun 15, 2022
@ti-srebot
ddl: support index regions and updating the existed table rule when c…
921e644 
…hanging partition (#33925) (#34024)

close #33929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rleungx rleungx

Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 component/pd severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: support index regions and updating the existed table rule when changing partition rleungx/tidb
5 participants
@xhebox @VelocityLight @mayjiang0203 @rleungx @ti-chi-bot