adjust

expression/generator/time_vec.go

@@ -27,7 +27,7 @@ import (
 	. "github.com/pingcap/tidb/expression/generator/helper"
 )
 
-const header = `// Copyright 2019 PingCAP, Inc.
+var addTime = template.Must(template.New("").Parse(`// Copyright 2019 PingCAP, Inc.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -43,21 +43,14 @@ const header = `// Copyright 2019 PingCAP, Inc.
 // Code generated by go generate in expression/generator; DO NOT EDIT.
 
 package expression
-`
 
-const imports = `import (
+import (
 	"github.com/pingcap/parser/mysql"
 	"github.com/pingcap/parser/terror"
 	"github.com/pingcap/tidb/types"
 	"github.com/pingcap/tidb/util/chunk"
-)`
-
-// TODO:
-// builtinAddTimeDateTimeNullSig.evalTime
-// builtinAddTimeStringNullSig.evalString
-// builtinAddTimeDurationNullSig.evalDuration
-// builtinAddTimeStringNullSig.evalString
-var addTime = template.Must(template.New("").Parse(`
+)
+
 {{ define "SetNull" }}{{if .Output.Fixed}}result.SetNull(i, true){{else}}result.AppendNull(){{end}} // fixed: {{.Output.Fixed }}{{ end }}
 {{ define "ConvertStringToDuration" }}
 		if !isDuration(arg1) {
@@ -252,7 +245,23 @@ func (b *{{.SigName}}) vectorized() bool {
 {{ end }}{{/* range */}}
 `))
 
-var testFile = template.Must(template.New("").Parse(`
+var testFile = template.Must(template.New("").Parse(`// Copyright 2019 PingCAP, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Code generated by go generate in expression/generator; DO NOT EDIT.
+
+package expression
+
 import (
 	"testing"
 
@@ -358,9 +367,6 @@ var tmplVal = struct {
 
 func generateDotGo(fileName string) error {
 	w := new(bytes.Buffer)
-	w.WriteString(header)
-	w.WriteString("\n")
-	w.WriteString(imports)
 	err := addTime.Execute(w, addTimeSigsTmpl)
 	if err != nil {
 		return err
@@ -375,7 +381,6 @@ func generateDotGo(fileName string) error {
 
 func generateTestDotGo(fileName string) error {
 	w := new(bytes.Buffer)
-	w.WriteString(header)
 	err := testFile.Execute(w, tmplVal)
 	if err != nil {
 		return err