plugin: fix audit plugin will cause tidb panic (#23803) (#23823)

pingcap · Apr 19, 2021 · 653b6ee · 653b6ee
1 parent e776461
commit 653b6ee
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/server/server.go b/server/server.go
@@ -477,6 +477,10 @@ func (s *Server) onConn(conn *clientConn) {
 	conn.Run(ctx)
 
 	err = plugin.ForeachPlugin(plugin.Audit, func(p *plugin.Plugin) error {
+		// Audit plugin may be disabled before a conn is created, leading no connectionInfo in sessionVars.
+		if sessionVars.ConnectionInfo == nil {
+			sessionVars.ConnectionInfo = conn.connectInfo()
+		}
 		authPlugin := plugin.DeclareAuditManifest(p.Manifest)
 		if authPlugin.OnConnectionEvent != nil {
 			sessionVars.ConnectionInfo.Duration = float64(time.Since(connectedTime)) / float64(time.Millisecond)