address comment, check plugin name

pingcap · Jan 13, 2019 · 5bbc246 · 5bbc246
1 parent a42f8e9
commit 5bbc246
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/cmd/pluginpkg/pluginpkg.go b/cmd/pluginpkg/pluginpkg.go
@@ -23,6 +23,7 @@ import (
 	"os/exec"
 	"path"
 	"path/filepath"
+	"strings"
 	"text/template"
 	"time"
 
@@ -98,6 +99,10 @@ func main() {
 	manifest["buildTime"] = time.Now().String()
 
 	pluginName := manifest["name"].(string)
+	if strings.Contains(pluginName, "-") {
+		log.Printf("plugin name should not contain '-'\n")
+		os.Exit(1)
+	}
 	if pluginName != filepath.Base(pkgDir) {
 		log.Printf("plugin package must be same with plugin name in manifest file\n")
 		os.Exit(1)