planner: fix goroutine leak problem in some unit tests (#26500) (#26506)

pingcap · Sep 16, 2021 · 1cae2c5 · 1cae2c5
1 parent f005851
commit 1cae2c5
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/planner/core/prepare_test.go b/planner/core/prepare_test.go
@@ -1022,11 +1022,12 @@ func (s *testPrepareSerialSuite) TestPrepareCacheWithJoinTable(c *C) {
 }
 
 func (s *testPlanSerialSuite) TestPlanCacheSnapshot(c *C) {
-	store, _, err := newStoreWithBootstrap()
+	store, dom, err := newStoreWithBootstrap()
 	c.Assert(err, IsNil)
 	tk := testkit.NewTestKit(c, store)
 	orgEnable := core.PreparedPlanCacheEnabled()
 	defer func() {
+		dom.Close()
 		err = store.Close()
 		c.Assert(err, IsNil)
 		core.SetPreparedPlanCache(orgEnable)
@@ -1073,11 +1074,12 @@ func (s *testPlanSerialSuite) TestPlanCacheSnapshot(c *C) {
 }
 
 func (s *testPlanSerialSuite) TestPlanCachePointGetAndTableDual(c *C) {
-	store, _, err := newStoreWithBootstrap()
+	store, dom, err := newStoreWithBootstrap()
 	c.Assert(err, IsNil)
 	tk := testkit.NewTestKit(c, store)
 	orgEnable := core.PreparedPlanCacheEnabled()
 	defer func() {
+		dom.Close()
 		store.Close()
 		core.SetPreparedPlanCache(orgEnable)
 	}()
@@ -1166,11 +1168,12 @@ func (s *testPlanSerialSuite) TestPlanCachePointGetAndTableDual(c *C) {
 }
 
 func (s *testPlanSerialSuite) TestIssue23671(c *C) {
-	store, _, err := newStoreWithBootstrap()
+	store, dom, err := newStoreWithBootstrap()
 	c.Assert(err, IsNil)
 	tk := testkit.NewTestKit(c, store)
 	orgEnable := core.PreparedPlanCacheEnabled()
 	defer func() {
+		dom.Close()
 		store.Close()
 		core.SetPreparedPlanCache(orgEnable)
 	}()