Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter: add more event types to ClassifyEvent #772

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

asddongmen
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #767

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@ti-chi-bot ti-chi-bot bot requested a review from js00070 January 31, 2024 07:36
@ti-chi-bot ti-chi-bot bot requested a review from rleungx January 31, 2024 07:36
@asddongmen asddongmen requested review from GMHDBJD and removed request for js00070 and rleungx January 31, 2024 07:36
@ti-chi-bot ti-chi-bot bot added the size/S label Jan 31, 2024
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 31, 2024
Copy link

ti-chi-bot bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-31 07:38:28.252960931 +0000 UTC m=+1551149.817258621: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 31, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5bb5178 into pingcap:master Jan 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants