Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the output of version #401

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Nov 13, 2020

Signed-off-by: xiang [email protected]

What problem does this PR solve?

the version of tools looks like v1.0.0~rc2+git.cccf51b, is strange.

What is changed and how it works?

update the version same with TiDB

Check List

Tests

  • No code

Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
@WangXiangUSTC WangXiangUSTC changed the title update version update the output of version Nov 13, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor Author

@GMHDBJD PTAL

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC merged commit d368cac into pingcap:master Nov 16, 2020
@WangXiangUSTC WangXiangUSTC deleted the xiang/version branch November 16, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants