Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff: fix send on closed channel panic #374

Merged
merged 5 commits into from
Jul 15, 2020
Merged

diff: fix send on closed channel panic #374

merged 5 commits into from
Jul 15, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Jul 15, 2020 •
edited
Loading

What problem does this PR solve?

fix issue #375

when cancel the context, the CheckTableData will return directly with channel checkResultCh closed, but some checkChunksDataEqual goroutines are still running, they may send results to the closed channel.

What is changed and how it works?

fix it

Check List

Tests

  • Unit test

@WangXiangUSTC WangXiangUSTC changed the title Xiang/fix panic diff: fix send on closed channel panic Jul 15, 2020
@WangXiangUSTC
Copy link
Contributor Author

/run-integration-test

@WangXiangUSTC
Copy link
Contributor Author

/run-integration-tests

@WangXiangUSTC
Copy link
Contributor Author

@csuzhangxc @GMHDBJD PTAL

GMHDBJD
GMHDBJD reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

csuzhangxc
csuzhangxc reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

csuzhangxc
csuzhangxc approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC merged commit eae8a56 into master Jul 15, 2020
@WangXiangUSTC WangXiangUSTC deleted the xiang/fix_panic branch July 15, 2020 11:30
@WangXiangUSTC WangXiangUSTC mentioned this pull request Jul 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
status/LGT2 type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WangXiangUSTC @csuzhangxc @GMHDBJD