*: update tidb #303
Merged
*: update tidb #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
|
/run-all-tests |
|
/run-integration-tests |
|
/run-integration-tests |
|
LGTM |
zimulala
reviewed
Dec 11, 2019
| if table.PKIsHandle { | ||
| pkIndex := &model.IndexInfo{ | ||
| Name: model.NewCIStr("PRIMARY"), | ||
| Primary: true, |
There was a problem hiding this comment.
Do we need to set the values of State and Unique?
|
/merge |
overvenus
added a commit
that referenced
this pull request
Dec 30, 2019
This reverts commit a41cb7f. Signed-off-by: Neil Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
tidb dependency is too old. Need to update.
What is changed and how it works?
Check List
Tests