importer: increase default batch, job_count, worker_count. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IANTHEREAL
reviewed
Jun 28, 2017
| fs.IntVar(&cfg.WorkerCount, "c", 1, "parallel worker count") | ||
| fs.IntVar(&cfg.JobCount, "n", 1, "total job count") | ||
| fs.IntVar(&cfg.Batch, "b", 1, "insert batch commit count") | ||
| fs.IntVar(&cfg.WorkerCount, "c", 2, "parallel worker count") |
There was a problem hiding this comment.
I make it 2 because default JobCount is 10000;
There was a problem hiding this comment.
how about 10,1000,10000?
|
LGTM |
3pointer
pushed a commit
to 3pointer/tidb-tools
that referenced
this pull request
Oct 29, 2021
refine output dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous default batch value is 1, which is too slow.
@GregoryIan @iamxy PTAL