Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/etcd: return revision when create key #286

Merged
merged 2 commits into from
Nov 18, 2019
Merged

pkg/etcd: return revision when create key #286

merged 2 commits into from
Nov 18, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

return revision when creating a key. used for dm

Check List

Tests

  • Unit test

csuzhangxc
csuzhangxc reviewed Nov 18, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

csuzhangxc
csuzhangxc reviewed Nov 18, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lichunzhu
lichunzhu approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu merged commit a741d9a into pingcap:master Nov 18, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/etcd_create branch November 18, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
priority/unimportant status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WangXiangUSTC @csuzhangxc @lichunzhu