driver/reader: return the next offset instead of sarama.OffsetNewest #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose the ts in queue is 1 2 3 we use ts = 3 to seek the offset, it return sarama.OffsetNewest at the same time some data pushed to queue it become 1 2 3 4 we use sarama.OffsetNewest to consume, so we lost the msg ts = 4
|
LGTM |
|
LGTM |
july2993
added a commit
that referenced
this pull request
Feb 21, 2019
…198) Suppose the ts in queue is 1 2 3 we use ts = 3 to seek the offset, it return sarama.OffsetNewest at the same time some data pushed to queue it become 1 2 3 4 we use sarama.OffsetNewest to consume, so we lost the msg ts = 4
july2993
added a commit
that referenced
this pull request
Feb 21, 2019
…198) Suppose the ts in queue is 1 2 3 we use ts = 3 to seek the offset, it return sarama.OffsetNewest at the same time some data pushed to queue it become 1 2 3 4 we use sarama.OffsetNewest to consume, so we lost the msg ts = 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
relate issue: https://internal.pingcap.net/jira/browse/TOOL-932
Suppose the ts in queue is
1 2 3
we use ts = 3 to seek the offset, it return sarama.OffsetNewest
at the same time some data pushed to queue it become
1 2 3 4
we use sarama.OffsetNewest to consume, so we lost the msg ts = 4
What is changed and how it works?
return the next offset instead of sarama.OffsetNewest
Check List
Tests
Code changes
Side effects
Related changes