pump client: compatible with kafka version tidb-binlog && add unit test #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@july2993 @GregoryIan PTAL |
WangXiangUSTC
changed the title
added 2 commits
December 10, 2018 15:10
IANTHEREAL
reviewed
Dec 13, 2018
IANTHEREAL
reviewed
Dec 13, 2018
added 2 commits
December 14, 2018 11:23
|
@GregoryIan @july2993 PTAL again |
added 2 commits
December 14, 2018 17:34
july2993
reviewed
Dec 14, 2018
| } | ||
|
|
||
| // NewLocalUnixSelector returns a LocalUnixSelector. | ||
| func NewLocalUnixSelector() PumpSelector { |
There was a problem hiding this comment.
return LocalUnixSelector type
There was a problem hiding this comment.
you mean update comment?
IANTHEREAL
reviewed
Dec 14, 2018
|
rest LGTM |
|
are any stability test running? @WangXiangUSTC |
|
already run a test before @GregoryIan |
|
can you describe your test or paste a link about it? |
|
@july2993 PTAL |
IANTHEREAL
reviewed
Dec 18, 2018
|
https://internal.pingcap.net/jira/browse/TOOL-718 |
|
LGTM |
WangXiangUSTC
added a commit
to WangXiangUSTC/tidb-tools
that referenced
this pull request
Mar 25, 2019
IANTHEREAL
pushed a commit
that referenced
this pull request
Mar 29, 2019
… strategy config (#223) * pump client: compatible with kafka version tidb-binlog && add unit test (#139) * pump client: write commit binlog will never return error (#148) * pkg watcher: move watcher from tidb-enterprise-tools (#146) * pump client: increase retry time, and refine some code (#158) * pump client: add initial log function (#165) * pump client: support change select pump's strategy (#221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
make pump client compatible with kafka version tidb-binlog
What is changed and how it works?
add binlog socket as args when create pumps client, and if binlog socket is not empty, will always use local pump to write binlog.
Check List
Tests
Related changes