Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terraform aws operator values #946

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Fix terraform aws operator values #946

merged 2 commits into from
Sep 25, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Sep 24, 2019

Signed-off-by: Aylei [email protected]

What problem does this PR solve?

close #925

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Does this PR introduce a user-facing change?:

The custom tidb-operator values can be properly set now in terraform script for AWS .

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Sep 25, 2019

/run-e2e-in-kind

@aylei
Copy link
Contributor Author

aylei commented Sep 25, 2019

/run-e2e-tests

@aylei aylei merged commit 8b9109e into pingcap:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Terraform: cannot specify values.yaml for tidb-operator
3 participants