deploy/gcp: fix apply issue and simplify terraform configuration #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we should not create the file again with its content. terraform will not skip creation even if the content does not change. so terraform will destroy the file and the new file cannot be created anymore
cofyc
commented
Sep 2, 2019
| @@ -20,7 +9,8 @@ provider "helm" { | |||
| # we defer initialization by using load_config_file argument. | |||
| # See https://github.com/pingcap/tidb-operator/pull/819#issuecomment-524547459 | |||
| config_path = local.kubeconfig | |||
| load_config_file = local_file.kubeconfig.filename != "" ? true : false | |||
| # used to delay helm provisioner initialization in apply phrase | |||
| load_config_file = module.tidb-operator.get_credentials_id != "" ? true : null | |||
There was a problem hiding this comment.
module.tidb-operator.get_credentials_id can serve same purpose
|
add a release note? |
weekface
approved these changes
Sep 3, 2019
gregwebs
approved these changes
Sep 3, 2019
|
/run-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #859
we should not create the file again with its content. terraform will not
skip creation even if the content does not change. so terraform will
destroy the file and the new file cannot be created anymore
Check List
Tests
Steps to test:
Does this PR introduce a user-facing change?: