-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch to reclaim pv when scale in tikv or pd #1037
Conversation
Co-Authored-By: Aylei <[email protected]>
Co-Authored-By: DanielZhangQD <[email protected]>
…perator into add-switch-to-clean-pvc
/run-e2e-in-kind |
…perator into add-switch-to-clean-pvc
/run-e2e-in-kind |
1 similar comment
/run-e2e-in-kind |
Can we add this feature to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -10,6 +10,7 @@ tests/images/e2e/tidb-cluster/ | |||
tests/images/e2e/tidb-backup/ | |||
tests/images/e2e/tidb-operator/ | |||
tests/images/e2e/manifests/ | |||
manifests/crd-verify.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yisaer better to update verify script to use a temporary file
/run-e2e-in-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <[email protected]>
What problem does this PR solve?
Resolve #908
What is changed and how does it work?
Add
enablePVReclaim
option incharts/tidbcluster/values.yaml
,set this option totrue
to enable PV reclaim function.Check List
Tests
Code changes
Related changes
Does this PR introduce a user-facing change?: